-
Notifications
You must be signed in to change notification settings - Fork 12
Feat/pass context req res to method #863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #863 +/- ##
==========================================
+ Coverage 98.96% 98.99% +0.03%
==========================================
Files 9 9
Lines 289 299 +10
Branches 43 43
==========================================
+ Hits 286 296 +10
Misses 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is almost what we want, but maybe it's cleaner to just , major version bump. The thought here is that we can do (context,params) as a required interface going forward on a major version bump. it sucks because you'll have to rewrite your method wrapping but the end benefits is that we can then natively support auth and other kinds of request headers in a much more straight forward way
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
8fbd61f
to
48713fb
Compare
Adds passing
this
to a method call sso you can get at{req, res}
as an example for headers etc.