Skip to content

Conversation

shanejonas
Copy link
Member

@shanejonas shanejonas commented May 27, 2025

Adds passing this to a method call sso you can get at {req, res} as an example for headers etc.

Copy link

codecov bot commented May 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.99%. Comparing base (4c7b8a3) to head (1dc9df7).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #863      +/-   ##
==========================================
+ Coverage   98.96%   98.99%   +0.03%     
==========================================
  Files           9        9              
  Lines         289      299      +10     
  Branches       43       43              
==========================================
+ Hits          286      296      +10     
  Misses          3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@zcstarr zcstarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is almost what we want, but maybe it's cleaner to just , major version bump. The thought here is that we can do (context,params) as a required interface going forward on a major version bump. it sucks because you'll have to rewrite your method wrapping but the end benefits is that we can then natively support auth and other kinds of request headers in a much more straight forward way

Copy link
Member

@zcstarr zcstarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shanejonas shanejonas changed the base branch from feat/allow-passing-express-app-for-integration to master May 29, 2025 16:53
@shanejonas shanejonas force-pushed the feat/pass-context-req-res-to-method branch from 8fbd61f to 48713fb Compare May 29, 2025 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants