Feat/esm #350
Open
Feat/esm #350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #350 +/- ##
==========================================
+ Coverage 99.27% 99.75% +0.47%
==========================================
Files 11 11
Lines 416 404 -12
Branches 64 56 -8
==========================================
- Hits 413 403 -10
+ Misses 3 1 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ing to clientjs. We introduce ESM to make clientjs work better with modern ts/js build systems. This is a breaking change and the old commonjs version will remain on the feature branch version 1.x.x of the build. BREAKING CHANGE: CommonJS and ES5 no longer supported
shanejonas
reviewed
Oct 25, 2025
| working_directory: ~/client-js | ||
| docker: | ||
| - image: cimg/node:20.11.0 | ||
| - image: cimg/node:24.10.0 |
There was a problem hiding this comment.
I don't think there is an official one, regardless I think it's maybe better to stay on node runtime maybe for a cpl iterations, as bun runtime is so new and most users are probably going to be using node.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.