Skip to content

avoid conflict in Promise and Iterator #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 18, 2025
Merged

avoid conflict in Promise and Iterator #55

merged 1 commit into from
Feb 18, 2025

Conversation

koonpeng
Copy link
Collaborator

Not sure if it is just me but rust-analyzer thinks Promise is an Iterator and Promise::take conflicts with Iterator::take. Switched to the full form avoid the conflict.

@koonpeng
avoid conflict in take()
5c9e3b5 
Signed-off-by: Teo Koon Peng <[email protected]>
@koonpeng koonpeng requested a review from mxgrey February 18, 2025 07:26
mxgrey
mxgrey approved these changes Feb 18, 2025
View reviewed changes
Copy link
Contributor

@mxgrey mxgrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix!

I've been seeing this for a long time but I shrugged it off since it's clearly a bug in rust-analyzer rather than a bug in our code. But this is a great workaround 👍

@mxgrey mxgrey merged commit 0ee3fe2 into main Feb 18, 2025
6 checks passed
@mxgrey mxgrey deleted the koonpeng/fix-promise-iterator-conlfict branch February 18, 2025 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxgrey mxgrey mxgrey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@koonpeng @mxgrey