v5.0.x: Add opal_clock_gettime() / opal_clock_getres() #9832
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of Dec 2021, it turns out that CLOCK_MONOTONIC can actually go backwards on macOS (!). Add two simple portable wrappers that use CLOCK_MONOTONIC_RAW on Darwin (which doesn't go backwards) and CLOCK_MONOTONIC everywhere else. Additionally, if the underlying OS does not have clock_gettime(), use gettimeofday() instead. Signed-off-by: Jeff Squyres <[email protected]> (cherry picked from commit c74f80a)
Update MPI_Wtick and MPI_Wtime to use the portable wrappers opal_clock_gettime() and opal_clock_getres(). Signed-off-by: Jeff Squyres <[email protected]> (cherry picked from commit e72b4e6)
bosilca
approved these changes
Jan 4, 2022
bwbarrett
approved these changes
Jan 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the v5.0.x PR for master PR #9798.
See individual commit messages for details.