ofi: Refactor MCA vars / fix output level #9454
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ofi common refactoring patches broke handling of the verbose flag because I forgot that the input variable has to live longer than the function (sigh). Move the output level variable to be a global variable. Add error checking to the entire mca registration path, since it was notably lacking. Even before the refactor, we didn't handle re-setting verbosity after registering synonyms properly. This patch probably isn't perfect in that regards, but at least is *consistent* in what we do. Signed-off-by: Brian Barrett <[email protected]>
wckzhang
approved these changes
Oct 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ofi common refactoring patches broke handling of
the verbose flag because I forgot that the input
variable has to live longer than the function (sigh).
Move the output level variable to be a global variable.
Add error checking to the entire mca registration
path, since it was notably lacking.
Even before the refactor, we didn't handle re-setting
verbosity after registering synonyms properly. This
patch probably isn't perfect in that regards, but
at least is consistent in what we do.
Signed-off-by: Brian Barrett [email protected]