build: Avoid accidental calls to AC_PROG_CC #9448
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The IBM CI (GNU/Scale) build failed! Please review the log, linked below. Gist: https://gist.github.com/3137d930c96fe10b9f151381c36261cf |
Member
|
@bwbarrett Something in there ended up zeroing out the wrapper compiler specification: |
bwbarrett
force-pushed
the
cleanup/avoid-early-ac-prog-cc-calls
branch
3 times, most recently
from
9f84187 to
b4b0309
Compare
Reorder some of the early configure tests to avoid accidently calling AC_PROG_CC before the C compiler section, which will also ensure those tests are run with the same option flags as the rest of the tests. Reorder the wrapper compiler initialization, as it depended on these accidental calls to AC_PROG_CC. To make the late call to the wrapper compiler code work, save the "bare" CC (before Autoconf macros add stuff to it) in the env variable OPAL_CC, similar to the AC_DEFINE of the same name. To keep this from happening again, cause an Autoconf error if Autoconf expands AC_PROG_CC before the call to OPAL_SETUP_CC, and put in some AC_REQUIRE statements to better state dependencies. Signed-off-by: Brian Barrett <[email protected]>
bwbarrett
force-pushed
the
cleanup/avoid-early-ac-prog-cc-calls
branch
from
b4b0309 to
fcbec27
Compare
Member
Author
|
bot:aws:retest (java error) |
jsquyres
approved these changes
Oct 6, 2021
Contributor
|
Do we need any of this in PMIx/PRRTE? |
Member
Author
It's mostly defensive code. There were a couple bugs in OMPI that don't look like they are in PMIx (based on a quick look). The patch almost certainly won't apply cleanly, so I'm not sure how much I'd worry about it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reorder some of the early configure tests to avoid
accidently calling AC_PROG_CC before the C compiler
section, which will also ensure those tests are run
with the same option flags as the rest of the tests.
To keep this from happening again, cause an Autoconf
error if Autoconf expands AC_PROG_CC before the
call to OPAL_SETUP_CC.
Signed-off-by: Brian Barrett [email protected]