v4.1.x: odls/base: Fix abormal cleanup when app is wrapped #9262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The scenario is that we have a wrapper process placed before the
MPI application:
```shell
mpirun -np 2 wrapper ./hello_c
```
* If `hello_c` crashes and `wrapper` detects it, then `wrapper` will
exit with a non-zero exit status. The orted will notice that and
start a kill process for all local processes.
- The orted will send `SIGKILL` to the `wrapper` process, and that
process will terminate and leave the `hello_c` running. The `hello_c`
will continue to run (in this test case will wait in `MPI_Finalize`)
and the job will seem to hang.
* This commit does two things each will fix this scenario.
1. After killing the process mark it as not alive since we are not
going to wait on it. This prevents orted_cmd from seeing the process
as alive and waiting for it to complete (note that the pid is set
to `0` so we wouldn't be able to mark it correctly later even if
we did get a notice.
2. Instead of sending the `SIGKILL` signal to just the `PID` of `wrapper`
send it to `-PID` so that the kernel will send the signal to the
whole process group under `wrapper` as well. This will case the
`hello_c` program to terminate as well.
Signed-off-by: Austen Lauria <[email protected]>
(cherry picked from commit 9a849b5)
Member
|
Ref comment #9261 (comment) |
jjhursey
approved these changes
Aug 17, 2021
Contributor
|
Please see explanation in #9261 - this patch is incorrect and should not be merged. |
Contributor
Author
|
Verified this is a dup of: #3773 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MPI application:
hello_ccrashes andwrapperdetects it, thenwrapperwillexit with a non-zero exit status. The orted will notice that and
start a kill process for all local processes.
SIGKILLto thewrapperprocess, and thatprocess will terminate and leave the
hello_crunning. Thehello_cwill continue to run (in this test case will wait in
MPI_Finalize)and the job will seem to hang.
going to wait on it. This prevents orted_cmd from seeing the process
as alive and waiting for it to complete (note that the pid is set
to
0so we wouldn't be able to mark it correctly later even ifwe did get a notice.
SIGKILLsignal to just thePIDofwrappersend it to
-PIDso that the kernel will send the signal to thewhole process group under
wrapperas well. This will case thehello_cprogram to terminate as well.Signed-off-by: Austen Lauria [email protected]
(cherry picked from commit 9a849b5)