opal: disable the __atomic built-in atomics by default on AArch64 #8413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjelmn
force-pushed
the
v4.1.x_use_hand_written_atomics_for_aarch64_by_default_because_the_builtins_are_inferior_for_our_usage
branch
from
3564f1a to
37b7d87
Compare
Member
|
FWIW, this had come up just before the 4.1.0 release. We observe this on one of our aarch64 instances as well. @jsquyres had some thoughts on changing the default, tagging him for review. |
Member
Author
|
@rajachan Yeah. I think now that AArch64 is getting into more hands there is good reason to push this to v4.1.x and v4.0.x. We want to provide the best out of the box performance on Apple Silicon. |
Member
|
Let's put a bullet in NEWS since we're changing it past 4.1.0. But this is such an inner-magic change that I don't think anyone will notice (other than better performance). |
Member
Author
|
@jsquyres Ok. Will do that now. |
Benchmarks are showing better performance when not using the __atomic built-ins on this arch. This PR disables them by default for this architecture only. Signed-off-by: Nathan Hjelm <[email protected]>
hjelmn
force-pushed
the
v4.1.x_use_hand_written_atomics_for_aarch64_by_default_because_the_builtins_are_inferior_for_our_usage
branch
from
37b7d87 to
3248a77
Compare
Member
Author
|
Done. |
bosilca
approved these changes
Jan 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benchmarks are showing better performance when not using the __atomic
built-ins on this arch. This PR disables them by default for this
architecture only.
Signed-off-by: Nathan Hjelm [email protected]