btl/ofi: fix memory leaks in error handling path #8316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, mca_btl_ofi_put (get, aop, afop, acswp) will allocate a mca_btl_ofi_rdma_completion_t object and use it as the context for fi_write/fi_read/fi_atomic/fi_fetch_atomic/fi_compare_atomic. In normal code path, this completion object when processing completion entry. However, when error happened when calling fi_write/fi_read/fi_atomic/fi_fetch_atomic/fi_compare_atomic, there will be no completion entry from libfabric, in this case the completion object's memory is leaked. This patch address the issue by calling opal_free_list_return() in the error handling code path. Signed-off-by: Wei Zhang <[email protected]>
rajachan
approved these changes
Dec 23, 2020
Contributor
Author
|
Thanks for merging! will open PR against other branch |
Contributor
Author
|
PR to 4.1.x: #8318 4.0.x branch does not seem to have btl/ofi component though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, mca_btl_ofi_put (get, aop, afop, acswp) will allocate
a mca_btl_ofi_rdma_completion_t object and use it as the context
for fi_write/fi_read/fi_atomic/fi_fetch_atomic/fi_compare_atomic.
In normal code path, this completion object when processing completion
entry. However, when error happened when calling
fi_write/fi_read/fi_atomic/fi_fetch_atomic/fi_compare_atomic,
there will be no completion entry from libfabric, in this case the
completion object's memory is leaked.
This patch address the issue by calling opal_free_list_return() in
the error handling code path.
Signed-off-by: Wei Zhang [email protected]