Fix memory leak in configure, which prevents leak sanitizer usage #7953
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@cniethammer I'm not entirely understanding what problem it is that you're fixing here. Yes, the |
Contributor
Author
|
This matters if I build Open MPI with sanitizers, e.g. |
Member
|
Got it. Can you put that in the commit message and/or in a comment in the code? |
If building Open MPI with sanitizers, e.g $ configure CC=clang CFLAGS=-fsanitize=address .... configure test programs are also build with the sanitizers and will report errors resulting in configure to fail. Signed-off-by: Christoph Niethammer <[email protected]>
cniethammer
force-pushed
the
configure-leak-fix
branch
from
93924a2 to
6564c1b
Compare
Contributor
Author
|
@jsquyres Updated the commit message |
jsquyres
approved these changes
Jul 21, 2020
Contributor
|
Should this be backported to the release branches? |
Contributor
Author
|
Yes, would be good to have this in at least 4.1.x for testing |
Member
|
Might as well do v4.0.x, too. |
This was referenced Jul 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Christoph Niethammer [email protected]