btl: change argument type of BTL receive callbacks #7913
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsquyres
reviewed
Jul 7, 2020
Member
jsquyres
left a comment
jsquyres
left a comment
There was a problem hiding this comment.
I can't give much of a review of the BTL/OB1 changes, but I can say that it generally compiled/ran fine for me (including usNIC) -- i.e., similar to #7830 (comment), I got some random errors, but I think those are unrelated to this PR.
opal/mca/btl/usnic/btl_usnic_recv.c
Outdated
| (int)bseg->us_btl_header->tag); | ||
| #endif | ||
| reg->cbfunc(&module->super, hdr->tag, &seg->rs_desc, reg->cbdata); | ||
| seg->rs_desc.endpoint = endpoint; |
Member
There was a problem hiding this comment.
Watch for tabs here (vs. spaces).
opal/mca/btl/usnic/btl_usnic_recv.c
Outdated
| /* mca_pml_ob1_recv_frag_callback_frag() */ | ||
| reg->cbfunc(&module->super, chunk_hdr->ch_hdr.tag, | ||
| &desc, reg->cbdata); | ||
| desc.endpoint = endpoint; |
Member
Author
There was a problem hiding this comment.
Yeah. Missing the emacs decorations I suspect. Will fix.
opal/mca/btl/usnic/btl_usnic_recv.h
Outdated
| seg->rs_segment.seg_len = bseg->us_btl_header->payload_len; | ||
| reg->cbfunc(&module->super, bseg->us_btl_header->tag, | ||
| &seg->rs_desc, reg->cbdata); | ||
| seg->rs_desc.endpoint = endpoint; |
opal/mca/btl/usnic/btl_usnic_recv.h
Outdated
| seg->rs_segment.seg_len = bseg->us_btl_header->payload_len; | ||
| reg->cbfunc(&module->super, bseg->us_btl_header->tag, | ||
| &seg->rs_desc, reg->cbdata); | ||
| seg->rs_desc.tag = bseg->us_btl_header->tag; |
hjelmn
force-pushed
the
btl_base_atomics_are_awesome
branch
from
13bcea3 to
9a50fda
Compare
bosilca
reviewed
Jul 8, 2020
Member
There was a problem hiding this comment.
Looks good, but there are a lot of unnecessary changes making the patch more massive than it is. I don't want to be pedantic but I would have rather kept the changes to only the necessary ones.
Plus there are some additions that are not related to the scope of the patch (the new MCA_BTL_TAG_BASE_* I marked in my comments).
hjelmn
force-pushed
the
btl_base_atomics_are_awesome
branch
from
9a50fda to
22e697b
Compare
This commit updates the btl interface to change the parameters passed to receive callbacks. The interface used to pass the tag, a btl base descriptor, and the callback context. Most of the values in the btl base descriptor were unused and only helped simplify the callbacks from the self btl. All of the arguments have now been replaced with a single receive callback descriptor. This descriptor contains the incoming endpoint, data segment(s), tag, and callback context. All btls have been updated to use the new callback and the btl interface version has been bumped to v3.2.0. As part of this change the descriptor argument (and the segments contained within it) have been marked as const. The were treated as const before but this change could allow the compiler to make better optimization decisions and will enforce that the callback does not attempt to change the data in the descriptor. Signed-off-by: Nathan Hjelm <[email protected]>
hjelmn
force-pushed
the
btl_base_atomics_are_awesome
branch
from
22e697b to
88f51fb
Compare
bosilca
approved these changes
Jul 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the btl interface to change the parameters
passed to receive callbacks. The interface used to pass the tag,
a btl base descriptor, and the callback context. Most of the
values in the btl base descriptor were unused and only helped
simplify the callbacks from the self btl. All of the arguments
have now been replaced with a single receive callback descriptor.
This descriptor contains the incoming endpoint, data segment(s),
tag, and callback context. All btls have been updated to use
the new callback and the btl interface version has been bumped
to v3.2.0.
As part of this change the descriptor argument (and the segments
contained within it) have been marked as const. The were treated
as const before but this change could allow the compiler to make
better optimization decisions and will enforce that the callback
does not attempt to change the data in the descriptor.
Signed-off-by: Nathan Hjelm [email protected]