v4.0.x: pmix3x: Remove --enable-install-libpmix option #7884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This option is problematic, and has never worked in an Open MPI v4.0.x release tarball. Given that PMIx is now available elsewhere, it isn't worth fixing this option. See open-mpi#6228 for more detail. NOTE: This is a v4.0.x-specific commit because this option no longer exists on master because we deleted the entire pmix3x component. Hence, it's not possible to cherry-pick anything from master back to the v4.0.x branch. Signed-off-by: Jeff Squyres <[email protected]>
jsquyres
force-pushed
the
pr/die-enable-install-libpmix-die-die-die
branch
from
b686a0f to
447b140
Compare
rhc54
approved these changes
Jun 28, 2020
Member
Author
|
Talked about this one with RMs on 29 June 2020: IBM is going to check into and see if they are using this option internally (there's a thought they this may have been used internally in IBM). If IBM is using it, we probably don't want to fully remove this option -- but there may need to be more work to make this option work properly and/or put some bumpers around it to protect it from being mis-used / failing. If IBM is not using it, this PR should be merged so that v4.0.x and v4.1.x stay in sync. |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option is problematic, and has never worked in an Open MPI v4.0.x
release tarball. Given that PMIx is now available elsewhere, it isn't
worth fixing this option.
See #6228 for more detail.
NOTE: This is a v4.0.x-specific commit because this option no longer
exists on master because we deleted the entire pmix3x component.
Hence, it's not possible to cherry-pick anything from master back to
the v4.0.x branch.
Signed-off-by: Jeff Squyres [email protected]
Fixes #6228