mtl/ofi: break from progress loop when events are read #7802
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
bwbarrett
requested changes
Jun 11, 2020
Member
bwbarrett
left a comment
bwbarrett
left a comment
There was a problem hiding this comment.
Given that progress_event_count is fairly large, this seems like a good balance between latency and efficiency. However, given the rest of the loop, the right fix should be to remove the while (true) {, rather than just adding a break.
Member
|
ok to test |
Once any number of events are read, return immediately, rather than waiting for fi_cq_read() to return FI_EAGAIN or an error. This can improve observed latency if the user application is in a blocking call waiting for us to return. Deleting the while loop here also means ofi_progress_event_count serves as an upper bound for the total number of events read in a single call (with the while loop we might read far more, as long as new events continue to arrive). Signed-off-by: Eric Badger <[email protected]>
badgerious
force-pushed
the
mtl_ofi_cqread_break
branch
from
4046445 to
35dbc18
Compare
Contributor
Author
Good point. I've reorganized it to drop the while loop. |
bwbarrett
approved these changes
Jun 16, 2020
Member
|
bot:aws:retest - looks like clang37 had a hang running the connectivity test. |
Contributor
|
bot:ompi:retest |
3 similar comments
Contributor
|
bot:ompi:retest |
Contributor
|
bot:ompi:retest |
Contributor
|
bot:ompi:retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once any number of events are read, return immediately, rather than
waiting for fi_cq_read() to return FI_EAGAIN or an error. This can
improve observed latency if the user application is in a blocking call
waiting for us to return. Breaking here also means
ofi_progress_event_count serves as an upper bound for the total number
of events read in a single call (without it, we could read far more, as
long as new events continue to arrive).
Signed-off-by: Eric Badger [email protected]