Skip to content

Adding PMIx v3.1.5rc2 #7382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 11, 2020
Merged

Adding PMIx v3.1.5rc2 #7382

merged 1 commit into from
Feb 11, 2020

Conversation

@gpaulsen
Copy link
Member

@gpaulsen gpaulsen commented Feb 10, 2020

Adding PMIx v3.1.5rc2 from:
https://github.com/openpmix/openpmix/releases/tag/v3.1.5rc2

Signed-off-by: Geoffrey Paulsen [email protected]

@gpaulsen gpaulsen requested review from hppritcha and rhc54 February 10, 2020 23:15
@gpaulsen gpaulsen added this to the v4.0.3 milestone Feb 10, 2020
@gpaulsen
Copy link
Member Author

gpaulsen commented Feb 10, 2020 •
edited
Loading

I think I correctly PRed the PMIx v3.1.5rc2 here.

I only marked this as WIP-DNM! because I didn't first PR it to master, and then cherry-pick it here.

I posted this PR to v4.0.x so that we can get some CI on it before PMIX v3.1.5 releases.

Also once it DOES release, I don't know if we WANT to use PMIx v3.1.5 on master, or if we need something NEWER on master to support the PRRTE effort. If THAT's the case we can just remove this WIP-DNM! label and pickup the final release here on the v4.0.x branch when that comes in.

To my knowledge, we're not expecting any changes to PMIx v3.1.5 at this time.

@rhc54
Copy link
Contributor

rhc54 commented Feb 10, 2020

OMPI master needs to track PMIx master, which is where the submodule currently points. @jjhursey just released rc2 for v3.1.5 and I would expect that to pass rather quickly, so we should do the official release later this week.

@gpaulsen
Copy link
Member Author

gpaulsen commented Feb 10, 2020

I went ahead and removed the WIP-DNM! label, since master needs to track newer PMIx release.

rhc54
rhc54 approved these changes Feb 11, 2020
View reviewed changes
Copy link
Contributor

@rhc54 rhc54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guess it is okay - impossible to really review the entirety of the code base. Best to check by test.

@jjhursey
Copy link
Member

jjhursey commented Feb 11, 2020

bot:ibm:scale:retest
bot:ibm:scale:129:test

@hppritcha hppritcha merged commit eddb0ef into open-mpi:v4.0.x Feb 11, 2020
@gpaulsen gpaulsen deleted the topic/v4.0.x/pmix_v3.1.5rc2 branch February 11, 2020 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhc54 rhc54 rhc54 approved these changes

@hppritcha hppritcha hppritcha approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v4.0.3

Development

Successfully merging this pull request may close these issues.

4 participants

@gpaulsen @rhc54 @jjhursey @hppritcha