Bump hwloc requirement from 1.5 to 1.11 #7367
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brice Goglin <[email protected]>
Supported since hwloc 1.7 Signed-off-by: Brice Goglin <[email protected]>
Supported in hwloc 1.8 Signed-off-by: Brice Goglin <[email protected]>
They were replaced with NUMANODE/PACKAGE in 1.11 Signed-off-by: Brice Goglin <[email protected]>
It's not used, and XML is always enabled anyway Signed-off-by: Brice Goglin <[email protected]>
opal_hwloc_hwloc132_save_enable_pci doesn't exist anymore Signed-off-by: Brice Goglin <[email protected]>
…ut hwloc's verbs support is requested Signed-off-by: Brice Goglin <[email protected]>
bgoglin
force-pushed
the
hwloc1.11only
branch
from
1823aec to
9f75177
Compare
|
Unfortunately, RHEL/CentOS 6 has hwloc 1.5. So we don't really gain anything by upgrading our requirement to v1.11. 😢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #7362 and in preparation for discussing at the F2F meeting, I am removing some old configure checks for early hwloc versions, bumping the minimal supported release to 1.11 and removing some other unneeded configury.
According to https://repology.org/project/hwloc/versions all major distros switched to 1.11.x, and basically all of them except Centos8 are even at 2.x.
For the record 1.5.2 was released in 2013, 1.10.1 in 2015 and 1.11.0 in 2015/06.