SPML/UCX: fixed coverity issues #7332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitrygx
reviewed
Jan 23, 2020
oshmem/mca/spml/ucx/spml_ucx.c
Outdated
| opal_progress_register(spml_ucx_default_progress); | ||
|
|
||
| mca_spml_ucx.remote_addrs_tbl = (char ***)calloc(mca_spml_ucx.ucp_workers, sizeof(char ***)); | ||
| mca_spml_ucx.remote_addrs_tbl = (char ***)calloc(mca_spml_ucx.ucp_workers, sizeof(void*)); |
Member
There was a problem hiding this comment.
maybe sizeof(*mca_spml_ucx.remote_addrs_tbl)?
oshmem/mca/spml/ucx/spml_ucx.c
Outdated
| for (w = 0; w < ucp_workers; w++) { | ||
| mca_spml_ucx.remote_addrs_tbl[w] = (char **)calloc(nprocs, sizeof(char **)); | ||
| memset(mca_spml_ucx.remote_addrs_tbl[w], 0, nprocs * sizeof(char **)); | ||
| mca_spml_ucx.remote_addrs_tbl[w] = (char **)calloc(nprocs, sizeof(void*)); |
Member
There was a problem hiding this comment.
maybe sizeof(*mca_spml_ucx.remote_addrs_tbl[w])?
oshmem/mca/spml/ucx/spml_ucx.c
Outdated
| mca_spml_ucx.remote_addrs_tbl[w] = (char **)calloc(nprocs, sizeof(char **)); | ||
| memset(mca_spml_ucx.remote_addrs_tbl[w], 0, nprocs * sizeof(char **)); | ||
| mca_spml_ucx.remote_addrs_tbl[w] = (char **)calloc(nprocs, sizeof(void*)); | ||
| memset(mca_spml_ucx.remote_addrs_tbl[w], 0, nprocs * sizeof(void*)); |
Member
There was a problem hiding this comment.
memset() isn't needed here, since we use calloc() for memory allocation
hoopoepg
force-pushed
the
topic/fixed-coverity-issues
branch
from
5f15c1b to
9b16cac
Compare
hoopoepg
commented
Jan 23, 2020
Contributor
Author
hoopoepg
left a comment
hoopoepg
left a comment
There was a problem hiding this comment.
git commit -s
forgot about this... fixed
- fixed sizeof(char***) by variable datatype - fixed resorce leak in proc_add Signed-off-by: Sergey Oblomov <[email protected]>
hoopoepg
force-pushed
the
topic/fixed-coverity-issues
branch
from
9b16cac to
8543860
Compare
dmitrygx
approved these changes
Jan 23, 2020
artpol84
approved these changes
Jan 23, 2020
Contributor
|
Thanks, @hoopoepg ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
behaviour