Skip to content

v3.1.x: Add the missing code to check a return code #7290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 10, 2020
Merged

v3.1.x: Add the missing code to check a return code #7290

merged 1 commit into from
Jan 10, 2020

Conversation

@gpaulsen
Copy link
Member

@gpaulsen gpaulsen commented Jan 8, 2020

From: #7191

Signed-off-by: Geoffroy Vallee [email protected]
(cherry picked from commit de6f130)
Signed-off-by: Geoffrey Paulsen [email protected]

@gpaulsen gpaulsen requested a review from hppritcha January 8, 2020 20:20
@gvallee @gpaulsen
Add the missing code to check a return code
35a318a 
Signed-off-by: Geoffroy Vallee <[email protected]>
(cherry picked from commit de6f130)
Signed-off-by: Geoffrey Paulsen <[email protected]>
@gpaulsen gpaulsen added this to the v3.1.6 milestone Jan 8, 2020
@jsquyres jsquyres changed the title Add the missing code to check a return code v3.1.x: Add the missing code to check a return code Jan 9, 2020
@jsquyres
Copy link
Member

jsquyres commented Jan 9, 2020

bot:ompi:retest

@jsquyres
Copy link
Member

jsquyres commented Jan 9, 2020

bot:lanl:retest

@jsquyres
Copy link
Member

jsquyres commented Jan 9, 2020

@hppritcha Getting more errors on the Cray side. This looks like a local failure:

Open MPI autogen (buckle up!)

1. Checking tool versions

   Searching for autoconf
     Found autoconf version 2.69; checking version...
       Found version component 2 -- need 2
       Found version component 69 -- need 69
     ==> ACCEPTED
   Searching for libtoolize
  libtoolize not found
   Searching for glibtoolize
  glibtoolize not found

=================================================================
I could not find a recent enough copy of libtool.
I need at least 2.4.2, but only found the following versions:

    libtoolize: 
    glibtoolize: 

I am gonna abort.  :-(

Please make sure you are using at least the following versions of the
tools:

    GNU Autoconf: 2.69
    GNU Automake: 1.12.2
    GNU Libtool: 2.4.2
=================================================================
Build step 'Execute shell' marked build as failure
Finished: FAILURE

@jsquyres
Copy link
Member

jsquyres commented Jan 10, 2020

bot:ompi:retest

@jsquyres jsquyres merged commit db38d8f into open-mpi:v3.1.x Jan 10, 2020
@gpaulsen gpaulsen deleted the topic/v3.1.x/from_pr7191 branch December 14, 2020 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsquyres jsquyres jsquyres approved these changes

@hppritcha hppritcha hppritcha approved these changes

Assignees

No one assigned

Labels

RM approved Target: v3.1.x

Projects

None yet

Milestone

v3.1.6

Development

Successfully merging this pull request may close these issues.

4 participants

@gpaulsen @jsquyres @hppritcha @gvallee