Skip to content

Conversation

@hppritcha
Copy link
Member

to support the Cray Fortran compiler. Cray Fortran compiler does not
contain all symbol info in the module file, have to link with the *.o
created as part of module file compilation.

Signed-off-by: Howard Pritchard [email protected]

@hppritcha hppritcha requested a review from jsquyres November 21, 2019 21:03
jsquyres
jsquyres approved these changes Nov 21, 2019
@ggouaillardet
Copy link
Contributor

Could a compiler choose not to emit a .o file if there is no code in it?

@jsquyres
Copy link
Member

Could a compiler choose not to emit a .o file if there is no code in it?

The module in question has a variable instance in it -- so I think something must be emitted, right?

@hppritcha
Copy link
Member Author

@ggouaillardet has a point. I'll rework to check for case of a .o or not.

@jsquyres
Copy link
Member

A few lines above your code, there's this:

OPAL_LOG_COMMAND([$FC $FCFLAGS $FCFLAGS_f90 -c conftest-module.f90 $LDFLAGS $LIBS] ...

The -c means that a .o must be emitted, right?

to support the Cray Fortran compiler.  Cray Fortran compiler does not
contain all symbol info in the module file, have to link with the *.o
created as part of module file compilation.

Signed-off-by: Howard Pritchard <[email protected]>
@hppritcha hppritcha force-pushed the topic/support_for_cray_fortran branch from 05fadfe to 441bad9 Compare November 22, 2019 22:14
@hppritcha
Copy link
Member Author

@jsquyres and @ggouaillardet I could see that there might be some weird compiler that only emits a *.mod for this simple example. I tweaked the code some to try both with and without a *.o.

@hppritcha
Copy link
Member Author

cori is again discomfited
bot:ompi:retest

@jsquyres
Copy link
Member

@hppritcha I made a minor code suggestion in a new commit on this PR. Feel free to squash or discard.

@hppritcha
Copy link
Member Author

bot:ompi:retest

@hppritcha hppritcha merged commit 032a396 into open-mpi:master Nov 27, 2019
@hppritcha hppritcha deleted the topic/support_for_cray_fortran branch October 29, 2021 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants