Pr/cart comm file open fix #3703
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the cart_based_grouping aggregator strategy was not correctly updated during the last major rewrite of the aggregator selection algorithm. It is also not supposed to be called from file_open (but from file_set_view). Signed-off-by: Edgar Gabriel <[email protected]>
update the cartesian communicator based grouping strategy to match the other algorithms used in the aggregator selection process. Signed-off-by: Edgar Gabriel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the bug reported on the mailing list w.r.t. to using cartesian communicators when opening a file.