RFC: AUTHORS: reformat and include all git log email addresses #1581
Conversation
|
Multiline file are not easy to read/parse. Why not starting with the constant part (the name), followed by the current email address, and then all the institutions in order (current first). We can use a traditional CSV format (https://tools.ietf.org/html/rfc4180). |
AUTHORS
Outdated
| Rainer Keller, High Performance Computing Center, Stuttgart, Oak Ridge National Laboratory | ||
| [email protected] | ||
| [email protected] | ||
| Ralph Castain, Los Alamos National Laboratory, Cisco, Intel |
There was a problem hiding this comment.
Should add Greenplum to list
jsquyres
force-pushed
the
pr/AUTHORS-update
branch
from
c3aaa31 to
136189c
Compare
|
@rhc54 Done @bosilca Is machine-parsable a requirement? FWIW, here's the rationale for the initial format I submitted:
How about fully embracing the multi-line strategy with something like this: (note the blank line between people) |
|
Doing a quick grep for authors ( |
| [email protected] | ||
| Patrick Geoffray, Myricom | ||
| [email protected] | ||
| Pavel Shamis, Mellanox, Oak Ridge National Laboratory |
|
@bosilca Yes, I used |
|
@bosilca Forgot to mention: the output from the git commits sometimes reveals that people spell their names differently in different commits. So even the git knowledge is... imprecise. 😢 |
|
Yes, I noticed that. I wonder what are the email address on users.noreply.github.com ? Online modifications ? |
|
It looks like that comes if you do a PR merge and you haven't set a primary email address on your github account properly. |
|
After investigation it appears that if you protect your email address in your github profile, your UI actions automatically get associated with an users.noreply.github.com email. |
|
@bosilca Do you have something we can cite/link to about that? If so, I can add it to the github startup pages on our wiki (e.g., for new OMPI devs). Thanks! |
|
Empirical evidence ;) And github doc |
|
@bosilca Thanks -- now cited in https://github.com/open-mpi/ompi/wiki/InitialGithubSetup |
|
On a related note, it looks like the |
|
Test passed. |
jsquyres
force-pushed
the
pr/AUTHORS-update
branch
from
f86f5b5 to
02af4cf
Compare
Signed-off-by: Jeff Squyres <[email protected]>
Remove all @open-mpi-git-mirror entries; those are no longer necessary since the official migration to Git/Github. Add aliases for @users.noreply.github.com addresses. Add fixes for what look like accidental name mispellings / common-name-isms. Signed-off-by: Jeff Squyres <[email protected]>
jsquyres
force-pushed
the
pr/AUTHORS-update
branch
from
02af4cf to
36f6531
Compare
|
@goodell Good points; I updated the .mailmap file. |
|
@jsquyres my previous email ([email protected]) is not listed here, i do not use it any more, but should it be listed anyway ? |
|
@ggouaillardet I'm not sure I understand -- [email protected] is listed on https://github.com/open-mpi/ompi/pull/1581/files#diff-3d350169560e75d0cf9fc8e3574a3639R116. |
|
@ggouaillardet I'm sorry; I misunderstood your question. We're listing all the email addresses that appear in the output of |
9 participants
This is a proposal for reformatting the AUTHORS file. The intent is as follows:
What do people think of the new format? I'm a little concerned about the people who have gone through multiple organizations, and therefore have super-long text lines for their affiliation, e.g., Josh Hursey: https://github.com/open-mpi/ompi/pull/1581/files#diff-3d350169560e75d0cf9fc8e3574a3639R159
Signed-off-by: Jeff Squyres [email protected]