configure: only enable sync builtin atomics if they link #1508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the check for sync builtin atomics. AC_COMPILE_IFELSE is insufficient to check for the builtins. Need to use AC_LINK_IFELSE. Fixes open-mpi#1487 Signed-off-by: Nathan Hjelm <[email protected]>
Member
|
@hjelmn Thanks. Let's get this in as soon as CI finishes so that it's included in tonight's MTT. Thanks! |
Member
Author
|
Sure. Not sure why it was an AC_COMPILE_IFELSE in the first place. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the check for sync builtin atomics.
AC_COMPILE_IFELSE is insufficient to check for the builtins. Need to
use AC_LINK_IFELSE.
Fixes #1487
Signed-off-by: Nathan Hjelm [email protected]