Fix typo in LDFLAGS_save_xcode variable name #12720
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resulted in effectively overriding LDFLAGS='' on mac because save and restore variable named did not match Signed-off-by: Min RK <[email protected]>
Contributor
|
Thanks for the fix. We will also need to backport to v5.0.x where we also cherry-picked the commit. |
Contributor
Author
|
I think it was also backported to 4.1.x in #12663 |
This was referenced Aug 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes regression in #12650 where variable names LDFLAGS_save_xcode and LDFLAGS_xcode_save do not match, so LDFLAGS wasn't saved.
closes #12719