dist/buildrpm: fix incorrect test, which passed even with an empty path #12622
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Margolin <[email protected]>
Contributor
Author
|
Tagging @martinkontsek and @jsquyres - who are probably the best candidates to review this |
jsquyres
approved these changes
Jun 18, 2024
Member
jsquyres
left a comment
jsquyres
left a comment
There was a problem hiding this comment.
Wow; I had no idea that if test -n ; would return true!
Great find; thanks.
Member
|
@alex--m Can you cherry-pick this to v5.0.x? Thanks! |
This was referenced Jun 18, 2024
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stumbled on this by accident - turns out this condition is true and proceeds the
thenclause even if thelibfabric_pathwas never set and remained empty. Adding the quotes fixes this, so that only non-empty string (set by passing-ftobuildrpm.sh) would trigger the rest of libfabric detection logic (as probably intended originally).As the code runs today - every build adds these (libfabric-specific?) flags to the configure phase of the build - for no apparent reason:
LDFLAGS=-Wl,--build-id -Wl,-rpath -Wl,/lib64 -Wl,--enable-new-dtags