Minor fixes: comment correction and spelling "Registration" #12281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 26, 2024 23:09
Previously the comment suggested 0-byte sends were skipped, but this was no longer accurate. Update the comment to reflect the implementation. Signed-off-by: Luke Robison <[email protected]>
Update some comments and an enum value which where missing an R. Signed-off-by: Luke Robison <[email protected]>
jsquyres
approved these changes
Jan 26, 2024
devreal
approved these changes
Jan 28, 2024
Contributor
|
Will hold merge after 5.0.2 release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two commits: