opal/accelerator: allow 0 size copies #12229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it looks like zero size messages with valid buffer pointers can occur for send-to-self operations and with persistent request. The current accelerator components return however an error for size 0 making those tests fail in our testsuite. This commit allows size 0 messages, and returns immediatly. Signed-off-by: Edgar Gabriel <[email protected]>
wenduwan
approved these changes
Jan 12, 2024
bosilca
approved these changes
Jan 12, 2024
hppritcha
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it looks like zero size messages with valid buffer pointers can occur for send-to-self operations and with persistent request, even if the actual message size is not 0 bytes. The current accelerator components return however an error for size 0 making those tests fail in our testsuite.
This commit allows size 0 messages, and returns immediatly.