accelerator/cuda: Check for cuda devices #11617
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a check during component initialization for cuda capable devices. Does not select the component if no cuda capable devices are detected. Signed-off-by: William Zhang <[email protected]>
|
cuInit doesn't incur any cost except for the first invocation. I don't think there's any reason we can't call cuInit here, costs about 0.146 seconds during my testing on first invocation. |
|
oh I forgot to put this PR as part of Edgar's, I can do that |
|
Ah it's fine I think this can go in separately anyway. There's really no relation to Edgar's PR as coll cuda would have been compiled either way |
jsquyres
reviewed
Apr 26, 2023
| return NULL; | ||
| } | ||
|
|
||
| int count = 0; |
There was a problem hiding this comment.
Might as well move this line down below the cuInit() block (i.e., to where you know for sure that count will be used).
edgargabriel
approved these changes
Apr 26, 2023
|
@janjust would like someone at nVidia to review as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a check during component initialization for
cuda capable devices. Does not select the component if no cuda capable devices are detected.