ofi: NIC selection update #11565
Merged
ofi: NIC selection update #11565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 5, 2023
bwbarrett
previously requested changes
Apr 10, 2023
amirshehataornl
force-pushed
the
distances
branch
2 times, most recently
from
91096eb to
649236a
Compare
|
@amirshehataornl can you separate out pmix/prrte changes? |
amirshehataornl
force-pushed
the
distances
branch
from
649236a to
bebcc61
Compare
amirshehataornl
changed the title
amirshehataornl
changed the title
amirshehataornl
force-pushed
the
distances
branch
from
bebcc61 to
2c40260
Compare
The existing code in compare_cpusets assumed that some non_io ancestor of a PCI object should intersect with the cpuset of the proc. However, this is not true. There is a case where the non IO ancestor can be an L3. If there exists two L3s on the same NUMA and the process is bound to one L3, but the PCI object is connected to the other L3, then compare_cpusets() will return false. A better way to determine the optimal interface is by finding the distances of the interfaces from the current process. Then find out which of these interfaces is nearest the process and select it. Use the PMIx distance generation for this purpose. Move away from using deprecated PMIX macros and use the functions directly instead. Signed-off-by: Amir Shehata <[email protected]>
amirshehataornl
force-pushed
the
distances
branch
from
2c40260 to
d4e1ae5
Compare
|
Is this ready to go? |
|
yes, this is ready |
naughtont3
dismissed
bwbarrett’s stale review
The title and commit msg were update to address this review request.
|
@bwbarrett Can you rereview/approve. The changes were made to reflect your feedback. Thanks. |
bwbarrett
approved these changes
Apr 28, 2023
|
@awlauria this is ready to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ofi: NIC selection update
The existing code in compare_cpusets assumed that some non_io ancestor of a
PCI object should intersect with the cpuset of the proc. However, this is
not true. There is a case where the non IO ancestor can be an L3. If there
exists two L3s on the same NUMA and the process is bound to one L3, but
the PCI object is connected to the other L3, then compare_cpusets() will
return false.
A better way to determine the optimal interface is by finding the
distances of the interfaces from the current process. Then find out which
of these interfaces is nearest the process and select it.
Use the PMIx distance generation for this purpose.
Move away from using deprecated PMIX Macros and use the functions directly.
Avoid some compilation issues due to an error in PMIX code
Signed-off-by: Amir Shehata [email protected]