Fix uninitialized pointer in mca_smpl_ucx_register: Coverity CID 1498717 #11208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverity CID 1498717 Signed-off-by: David Wootton <[email protected]>
brminich
reviewed
Dec 13, 2022
brminich
approved these changes
Dec 14, 2022
Contributor
|
bot:retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coverity static analysis reports use of an uninitialized pointer at label error_unmap in mca_smpl_ucx_register
Fixes are to initialize ucx_mkey to NULL, to chance the error branch at line 743 to jump to error_out since ucx_mkey has not been set at this point, and check that ucx_mkey is not null before calling ucp_mem_unmap.
Signed-off-by: David Wootton [email protected]