Better ofi common quiet #11102
Merged
Better ofi common quiet #11102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d642af1.
about not knowing about local peers. Because with a singleton there aren't local peers so don't emit a message about locality to devices. Signed-off-by: Howard Pritchard <[email protected]>
Contributor
|
Was there push back against the previous change or did you change your mind? |
Member
Author
|
push back. I think this solution is better. I absolutely do not want ofi common chattering if a user wants to use singleton and there just happen to be multiple ofi devices on the node. |
wckzhang
approved these changes
Nov 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.