This repository was archived by the owner on Sep 30, 2022. It is now read-only.
Attribute "fixes" #142
Merged
Attribute "fixes" #142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
attributes from an attribute callback). (cherry picked from commit 4d55ae8)
Per discussion starting http://www.open-mpi.org/community/lists/users/2014/12/26018.php, at least note that OMPI does not allow adding or deleting attributes in an attribute copy or delete callback (or any of its children) on the same object on which the callback was invoked. (cherry picked from commit 9144517)
|
Adding @bosilca in this issue, just so he can share the email load. :-) |
|
Refer to this link for build results (access rights to CI server needed): |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I put "fixes" in quotes because I don't fully agree with the solution, but I don't fully disagree, either.
So pull it over, let it fix PETSc's current behavior. But at least also update our man pages to indicate that users should not expect adding/deleting attributes to work in attribute callback functions.
I reviewed George's code; the man pages hypothetically don't need reviewing.