[WIP] Various fixes for WORM mode #159
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
fvennetier
commented
Feb 27, 2019
fvennetier
commented
- obj: allow S3 MPU to work in worm mode
These require the deletion of a temporary manifest at the end of the upload.
murlock
reviewed
Feb 28, 2019
| @@ -663,6 +664,10 @@ def DELETE(self, req): | |||
| def _delete_object(self, req): | |||
| storage = self.app.storage | |||
| oio_headers = {'X-oio-req-id': self.trans_id} | |||
| # Allow swift3 to delete things from the multipart container | |||
| if (req.environ.get('swift.source') == 'S3' and | |||
| self.container_name.endswith(MULTIUPLOAD_SUFFIX)): | |||
There was a problem hiding this comment.
IMO it will not work with Container Hierachy or regexcontainer, maybe add a test regarding in oio-bucket-name ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.