fix: make OTEL evaluation event attribute types compliant to OTEL types

[lukas-reining]

This PR

• Makes OTEL evaluation event attributes compliant to OTEL Api types

[gemini-code-assist]

Summary of Changes

Hello @lukas-reining, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the OpenTelemetry integration by ensuring that evaluation event attributes strictly conform to OpenTelemetry API specifications. The primary goal is to improve data compatibility and reliability when exporting telemetry, particularly by correctly handling various data types, including complex objects, for seamless integration with OpenTelemetry-compliant systems.

Highlights

• Type Definition Alignment: Introduced a new AttributeValue type, aligning with OpenTelemetry's specification for attribute data types (string, number, boolean, and arrays of these primitives).
• Evaluation Event Attribute Update: Modified the EvaluationEvent interface to ensure its attributes property strictly adheres to the newly defined AttributeValue type, enhancing type safety and OpenTelemetry compliance.
• Object Value Serialization: Implemented logic to serialize object FlagValue instances into JSON strings when used as OpenTelemetry attributes, preventing type mismatches and ensuring data integrity for complex values.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request aims to make the OpenTelemetry evaluation event attributes compliant with OTEL API types. The changes introduce a new AttributeValue type and modify the logic for handling evaluation values. While the goal is correct, the implementation has a few issues. The new AttributeValue type definition is not fully compliant with the OTEL specification, a logic change has introduced a potential bug where both variant and value attributes could be set, and there's a missed opportunity to handle array values more effectively. My review provides specific suggestions to address these points.