Skip to content
This repository was archived by the owner on May 9, 2025. It is now read-only.

Conversation

@Skarlso
Copy link
Contributor

@Skarlso Skarlso commented Nov 16, 2023

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

  • Related Issue # (issue)
  • Closes # (issue)
  • Fixes # (issue)

Remove if not applicable

Screenshots

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help
  • Separate ticket for tests # (issue/pr)

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Added to documentation?

  • 📜 README.md
  • 🙅 no documentation needed

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Skarlso Skarlso requested review from phoban01 and souleb November 16, 2023 08:36
@Skarlso Skarlso force-pushed the fix-deleting-reconiling-state branch from 9fa327c to 07b6600 Compare November 16, 2023 09:14
@Skarlso Skarlso force-pushed the fix-deleting-reconiling-state branch from 07b6600 to f9f0fa9 Compare November 16, 2023 09:20
Copy link
Contributor

@phoban01 phoban01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks this is much better!

@Skarlso Skarlso force-pushed the fix-deleting-reconiling-state branch from 54b3ff0 to 86f27b4 Compare November 17, 2023 13:13
@Skarlso Skarlso merged commit a6f5a3b into main Nov 17, 2023
@Skarlso Skarlso deleted the fix-deleting-reconiling-state branch November 17, 2023 13:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants