This repository was archived by the owner on May 9, 2025. It is now read-only.
remove repo name from spec, use object name #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks like there are still some tests that need to be fixed. |
Contributor
|
Looks like the |
phoban01
reviewed
May 12, 2023
Contributor
phoban01
left a comment
phoban01
left a comment
There was a problem hiding this comment.
Looks good, just need to update the gitlab provider package.
Contributor
Author
|
Good catch @phoban01, I actually had already done the GitLab changes, but somehow missed them when |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We made the decision to remove the
RepositoryNamefield from the spec. Instead the repo name will be based on the name of the object. In the case of the mpas-project-controller this will be<prefix(default=mpas)>-<project_name>