Skip to content

expose version number of PartMC and pybind11 via ppmc.__versions_of_build_time_dependencies__ #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 1, 2023
Merged

expose version number of PartMC and pybind11 via ppmc.__versions_of_build_time_dependencies__ #310

merged 2 commits into from
Dec 1, 2023

Conversation

@slayoo
Copy link
Member

@slayoo slayoo commented Nov 26, 2023

No description provided.

@slayoo slayoo requested a review from jcurtis2 November 27, 2023 00:06
@slayoo
Copy link
Member Author

slayoo commented Nov 27, 2023

@jcurtis2 here we expose versions of pybind11 and of PartMC via PyPartMC.__versions_of_build_time_dependencies dict. It's not exhaustive as we could/should also expose versions of CAMP, netCDF, SUNDIALS, etc... but let's treat this as a starting point - at least the way to do it would be depicted in 1.0.0, and we can add more later on (it's not that simple as in most cases some custom CMake logic + preprocessor define will be needed).

@slayoo slayoo changed the title expose version number of PartMC via ppmc.__versions_of_build_time_dependencies__ expose version number of PartMC and pybind11 via ppmc.__versions_of_build_time_dependencies__ Nov 27, 2023
@slayoo
Copy link
Member Author

slayoo commented Nov 30, 2023

update: CAMP and SUNDIALS versions added

@slayoo slayoo added this pull request to the merge queue Dec 1, 2023
Merged via the queue into open-atmos:main with commit 2a5ba8f Dec 1, 2023
@slayoo slayoo mentioned this pull request Dec 1, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcurtis2 jcurtis2 jcurtis2 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@slayoo @jcurtis2