fix: missing (1+qv) factor in calculation of derivative of rho_d when… #614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… accounting for water vapour rho_d(z) = rho(z) / (1 + qv(z)) therefore drho_d/dz = drho/dz / (1+ qv) - dqv/dz / (1 + qv)^2 _not_ drho_d/dz = drho/dz / (1+ qv) - dqv/dz / (1 + qv)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #614 +/- ##
==========================================
+ Coverage 92.69% 98.39% +5.70%
==========================================
Files 39 9 -30
Lines 1697 187 -1510
==========================================
- Hits 1573 184 -1389
+ Misses 124 3 -121 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Stale pull request message |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… accounting for water vapour
rho_d(z) = rho(z) / (1 + qv(z))
therefore drho_d/dz = drho/dz / (1+ qv) - dqv/dz / (1 + qv)^2
not(!) drho_d/dz = drho/dz / (1+ qv) - dqv/dz / (1 + qv)