Missing validation for integer range on query params

[cstaud]

Hi @mbuhot,
first let me thank you for keep this project running.

I noticed that the range for an integer query param isn't validated.
I wrote a failing test to make it clear what I mean.

Can you confirm?

Cheers.

[mbuhot]

Thanks @cstaud!

Yes I think I can see the problem in https://github.com/open-api-spex/open_api_spex/blob/master/lib/open_api_spex/cast/integer.ex#L13

Query Params are binaries, which the code converts to a Float, then calls cast recursively.

It then hits the clause where the value is rounded to integer and not validated further - it should make a recursive call to perform the range validations.

I’m on mobile for the next few days, but if you can modify the code I linked above to correctly handle casting integers from strings then I’ll be happy to merge it 🙂

[cstaud]

Yes you're right, was writing a comment at the exact same time ;-)
I will go for.

[mbuhot]

👍👍

[moxley]

Thanks @cstaud!