Convert string to atom when casting enum schema #101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is for convenience to save defining an explicit schema for the enum type.
mbuhot
commented
Apr 20, 2019
|
|
||
| assert Error.message_with_path(error2) == "#/3: Invalid integer. Got: string" | ||
| end | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
These tests moved into the new test/cast/enum_test.exs file
mbuhot
changed the title
moxley
reviewed
Apr 22, 2019
moxley
approved these changes
Apr 22, 2019
Enum.find a value in the Schema.enum that satisfies equivalent?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #60
Main changes in this PR are:
Casting from a string keyed map to a struct enum without an explicit object schema is disallowed - if a struct is required, then a schema should be defined.