Make Record.Args public so can be accessed by backends #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aheuermann
force-pushed
the
public_record_args
branch
from
7e1aef5 to
fa10849
Compare
|
Thank you! I see. If we expose the args we probably should expose fmt as well. I've been hesitant to expose these but I see your point. Hope it help! |
op
added a commit
that referenced
this pull request
Feb 6, 2016
Make Record.Args public so can be accessed by backends
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I'm creating a custom backend that logs errors to sentry.
Sentry has a method to create a StackTrace struct, which we do at the point the error is first created. We have a custom
errortype that we use to keep reference to it and then we log the error further up the stack.From within the custom backend, I'd like to be able to loop through
Record.Argsand see if any of the args are of this type so the stack can be passed to sentry. I accomplished this by simply makingArgspublic, but if there is preferred way of doing, let me know.