Skip to content

Conversation

Asalle
Copy link

@Asalle Asalle commented May 18, 2020

If not locked, this results in race:

  1. SetBackend(), backend.go:26 - reassigning the global variable (write)
func SetBackend(backends ...Backend) LeveledBackend {
	var backend Backend
  // ...

  // DARA RACE START
	defaultBackend = AddModuleLevel(backend)
  // DATA RACE END

	return defaultBackend
}
  1. IsEnabledFor(), logger.go:141 - accessing a default variable (read)
func (l *Logger) IsEnabledFor(level Level) bool {
	return defaultBackend.IsEnabledFor(level, l.Module) // DATA RACE HERE
}

If not locked, this results in race:
1. SetBackend(), backend.go:26 - reassigning the global variable (write)
```
func SetBackend(backends ...Backend) LeveledBackend {
	var backend Backend
  // ...

  // DARA RACE START
	defaultBackend = AddModuleLevel(backend)
  // DATA RACE END

	return defaultBackend
}
```

2. IsEnabledFor(), logger.go:141 - accessing a default variable (read)
```
func (l *Logger) IsEnabledFor(level Level) bool {
	return defaultBackend.IsEnabledFor(level, l.Module) // DATA RACE HERE
}
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant