TypeScript refactor, fix exact sizing (wrong branch) #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix bug when maxHeight === minHeight && maxWidth === minWidth. * This project has been converted to TypeScript with a generated type definition file. * The main method `imageFileResizer` accepts an options object argument instead of multiple individual arguments. * It returns a Promise instead of using a callback.
|
Wrong source branch. Creating another one |
peacechen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #94
Additionally:
imageFileResizeraccepts an options object argument instead of multiple individual arguments.This PR refactors the code as properly typed functions. The parameters are in a single options argument instead of multiple arguments. The TypeScript definition file is automatically generated.
Also addresses #93 , #78 , #62, and #50.
The code in this PR has been published as @peacechen/react-image-file-resizer pending merge.