Regexp issues, during signers extraction #224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/onflow/flow-playground/6mTHQC53KYcbF9Trpr27iCkjNchM [Deployment for f7d6694 failed] |
10thfloor
suggested changes
Feb 10, 2022
|
lgtm. Have not tested yet. |
Clear console.log calls
Add new line at the eof
Closed
10thfloor
approved these changes
Feb 15, 2022
10thfloor
added a commit
that referenced
this pull request
Feb 15, 2022
* Add parsing utility methods * Use extractSigners method from utils * Clear console.log calls * Add new line at the eof Co-authored-by: Mackenzie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #212
Potential improvement for language server as we should read this data from it and not parsing Cadence code on front-end.