API code submission for FLIP fest 'Playground Feature: Markdown READMEs 18' #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hichana
requested review from
janezpodhostnik,
psiemens and
turbolent
as code owners
MaxStalker
reviewed
Nov 3, 2021
MaxStalker
approved these changes
Nov 5, 2021
Contributor
MaxStalker
left a comment
MaxStalker
left a comment
There was a problem hiding this comment.
Thank you for participating in discussion and amendments to the code!
devbugging
approved these changes
Dec 16, 2021
janezpodhostnik
approved these changes
Dec 17, 2021
Contributor
janezpodhostnik
left a comment
janezpodhostnik
left a comment
There was a problem hiding this comment.
Looks good, and a really nice addition. I left two minor comments, if you want to address them.
| mutation($projectId: UUID!, $title: String!, $description: String!, $readme: String!, $persist: Boolean!) { | ||
| updateProject(input: { id: $projectId, title: $title, description: $description, readme: $readme, persist: $persist }) { | ||
| id | ||
| title |
Contributor
There was a problem hiding this comment.
There is a tabs vs. spaces issue here. I suggest converting to spaces, to match the lines above and below.
|
|
||
| bmStrict := bluemonday.StrictPolicy() | ||
|
|
||
| sanitizedTitle := bmStrict.Sanitize(p.Title) |
Contributor
There was a problem hiding this comment.
If it is not too much trouble I would really like to see a test where the description/title/readme is sanitized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: N/A
Description
This PR comprises the work by @J00LZ and @hichana on the FLIP fest 'Playground Feature: Markdown READMEs 18'. It adds a 'PROJECT' section that allows the user to create a title, description and readme for the project, with functionality integrated into the export feature (ex. the readme.md file exports with the rest of the code) and various redirects schemes to enhance the user experience.
The API supports the new functionality, with included tests to make sure the new data members are persisted to the API.
We made a comprehensive guide with screenshots to illustrate the features: https://github.com/hichana/flip-fest/blob/submissions/issue-%2318/milestone-%232/TeamExponential/submission/issue-18/milestone-2/TeamExponential/README.md
For contributor use:
Files changedin the Github PR explorer