Skip to content

Conversation

onerandomusername
Copy link
Owner

@onerandomusername onerandomusername commented Mar 21, 2023

depends on #227, GH-227

@onerandomusername onerandomusername force-pushed the feat/comment-linking branch 2 times, most recently from 206cb11 to 93051dd Compare March 21, 2023 18:50
@onerandomusername onerandomusername force-pushed the fix/github-markdown-rendering branch from 818a0e3 to 43a9fe3 Compare March 21, 2023 19:10
@onerandomusername onerandomusername changed the title feat: add automatic GitHub issue links feat: add automatic GitHub issue comment links Mar 21, 2023
@onerandomusername onerandomusername force-pushed the fix/github-markdown-rendering branch 2 times, most recently from d331fea to 26e8dab Compare March 21, 2023 19:41
@onerandomusername onerandomusername force-pushed the feat/comment-linking branch 2 times, most recently from 8803300 to 693754a Compare March 21, 2023 19:44
@onerandomusername onerandomusername force-pushed the fix/github-markdown-rendering branch from 53e8cf4 to e6b7424 Compare March 22, 2023 01:28
Base automatically changed from fix/github-markdown-rendering to main March 22, 2023 01:43
@onerandomusername onerandomusername marked this pull request as ready for review March 22, 2023 01:44
@onerandomusername onerandomusername force-pushed the feat/comment-linking branch 7 times, most recently from 781ef60 to 21a7701 Compare March 29, 2023 00:25
Copy link
Contributor

@shiftinv shiftinv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other fragment types I've seen, that aren't being handled yet:

@onerandomusername onerandomusername force-pushed the feat/comment-linking branch 7 times, most recently from 55ba134 to c4550ad Compare April 3, 2023 06:58
@onerandomusername
Copy link
Owner Author

Other fragment types I've seen, that aren't being handled yet:

* Linking to PR comments from file view: [onerandomusername/monty-python/pull/234/files/886b69691a644741c0dad0743744a957ebbdabc6#r1150000416](https://github.com/onerandomusername/monty-python/pull/234/files/886b69691a644741c0dad0743744a957ebbdabc6#r1150000416)
  
  * This doesn't necessarily have a commit hash, `files#r12341234` is also possible

Given the additional handling this requires on /files/ urls I personally don't want to implement this at the moment, but I wouldn't deny a pr to add it.

* Seems like older PR comments (< mid 2016) use `#discussion-diff-` instead of `pullrequestreview-`, e.g. [Ensure get_event_loop returns the running loop when called in a coroutine python/asyncio#355 (diff)](https://github.com/python/asyncio/pull/355#discussion-diff-65616522)
  
  * The link doesn't actually seem to fully work anymore in the gh UI, but the api docs still reference that fragment format

I can't recreate this, sorry.

* Linking to the first message of an issue or PR: [feat: add automatic GitHub issue comment links #228 (comment)](https://github.com/onerandomusername/monty-python/pull/228#issue-1634393638)

Changed...

@onerandomusername onerandomusername force-pushed the feat/comment-linking branch 2 times, most recently from 8861da7 to c6dcf25 Compare April 18, 2023 18:32
@onerandomusername onerandomusername force-pushed the feat/comment-linking branch 2 times, most recently from 2861548 to 9a238d8 Compare June 8, 2023 21:08
@onerandomusername onerandomusername enabled auto-merge (squash) June 8, 2023 21:25
@onerandomusername onerandomusername merged commit 0200d79 into main Jun 8, 2023
@onerandomusername onerandomusername deleted the feat/comment-linking branch June 8, 2023 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants