-
-
Notifications
You must be signed in to change notification settings - Fork 12
feat: add automatic GitHub issue comment links #228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
206cb11
to
93051dd
Compare
818a0e3
to
43a9fe3
Compare
518143e
to
4e52d89
Compare
d331fea
to
26e8dab
Compare
8803300
to
693754a
Compare
53e8cf4
to
e6b7424
Compare
32811e2
to
e961bf0
Compare
e961bf0
to
1d9d7b3
Compare
781ef60
to
21a7701
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other fragment types I've seen, that aren't being handled yet:
- Linking to PR comments from file view: https://github.com/onerandomusername/monty-python/pull/234/files/886b69691a644741c0dad0743744a957ebbdabc6#r1150000416
- This doesn't necessarily have a commit hash,
files#r12341234
is also possible
- This doesn't necessarily have a commit hash,
- Seems like older PR comments (< mid 2016) use
#discussion-diff-
instead ofpullrequestreview-
, e.g. python/asyncio#355 (diff)- The link doesn't actually seem to fully work anymore in the gh UI, but the api docs still reference that fragment format
- Linking to the first message of an issue or PR: #228 (comment)
55ba134
to
c4550ad
Compare
Given the additional handling this requires on /files/ urls I personally don't want to implement this at the moment, but I wouldn't deny a pr to add it.
I can't recreate this, sorry.
Changed... |
ee7b87f
to
aef8d6a
Compare
8861da7
to
c6dcf25
Compare
c6dcf25
to
58f24af
Compare
2861548
to
9a238d8
Compare
9a238d8
to
de29f12
Compare
depends on #227, GH-227