Enable fp16 runtime support for hip #988
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this feature need to be enabled conditionally depending on the arch properties? |
|
@ldrumm The only problematic one is Tahiti, which doesn't support fp16, but we decided to ignore Tahiti in this case. |
Tahiti is very old and not officially supported by ROCm anyway. This should be fine. |
JackAKirk
approved these changes
Oct 24, 2023
againull
pushed a commit
to intel/llvm
that referenced
this pull request
Oct 26, 2023
Enables fp16 support for AMD GPUs. Based on Zheming's previous work: [8488](#8488) Some test cases for e.g. images were disabled since they aren't supported Draft PR for enabling fp16 support in the unified-runtime: oneapi-src/unified-runtime#988 --------- Co-authored-by: Jin Z <[email protected]>
MartinWehking
force-pushed
the
adapters
branch
from
f988b8e to
5d304c5
Compare
|
Thanks. |
|
I have updated the target branch of this PR from the |
kbenzie
added a commit
to kbenzie/unified-runtime
that referenced
this pull request
Dec 6, 2023
Enable fp16 runtime support for hip
This was referenced Dec 6, 2023
kbenzie
added a commit
to kbenzie/intel-llvm
that referenced
this pull request
Dec 6, 2023
Combines the changes of the follow Unified Runtime pull requests: * oneapi-src/unified-runtime#1108 * oneapi-src/unified-runtime#988 * oneapi-src/unified-runtime#1071 * oneapi-src/unified-runtime#916 * oneapi-src/unified-runtime#1099
steffenlarsen
pushed a commit
to intel/llvm
that referenced
this pull request
Dec 8, 2023
Combines the changes of the follow Unified Runtime pull requests: * oneapi-src/unified-runtime#1108 * oneapi-src/unified-runtime#988 * oneapi-src/unified-runtime#1071 * oneapi-src/unified-runtime#916 * oneapi-src/unified-runtime#1099
kbenzie
added a commit
to kbenzie/unified-runtime
that referenced
this pull request
Dec 15, 2023
Enable fp16 runtime support for hip
callumfare
pushed a commit
to kbenzie/intel-llvm
that referenced
this pull request
Dec 18, 2023
Combines the changes of the follow Unified Runtime pull requests: * oneapi-src/unified-runtime#1108 * oneapi-src/unified-runtime#988 * oneapi-src/unified-runtime#1071 * oneapi-src/unified-runtime#916 * oneapi-src/unified-runtime#1099
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for intel/llvm#11626