Skip to content

Move OpenCL sources from intel/llvm to UR #960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 17, 2023
Merged

Move OpenCL sources from intel/llvm to UR #960

merged 2 commits into from
Oct 17, 2023

Conversation

fabiomestre
Copy link
Contributor

No description provided.

@fabiomestre fabiomestre changed the title Fabio/add opencl adapter Move OpenCL sources from intel/llvm to UR Oct 13, 2023
kbenzie
kbenzie reviewed Oct 13, 2023
View reviewed changes
Copy link
Contributor

@kbenzie kbenzie left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add this to the .github/CODEOWNERS file:

# OpenCL adapter
source/adapters/opencl          @oneapi-src/unified-runtime-opencl-write

@fabiomestre fabiomestre marked this pull request as ready for review October 16, 2023 12:43
@fabiomestre fabiomestre requested a review from a team as a code owner October 16, 2023 12:43
veselypeta
veselypeta approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@veselypeta veselypeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kbenzie
kbenzie approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@kbenzie kbenzie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 minor thing

@pbalcer
Copy link
Contributor

pbalcer commented Oct 16, 2023 •
edited
Loading

How do we plan on testing this adapter? using a CPU runtime (would it be possible to do that on GH-hosted runner)? something else?
Since this patch isn't adding a build/CTS workflow, there should at the very least be an issue to create one.

@kbenzie
Copy link
Contributor

kbenzie commented Oct 16, 2023

How do we plan on testing this adapter? using a CPU runtime (would it be possible to do that on GH-hosted runner)? something else?

These are the options:

  • Intel OpenCL CPU - could this be used on GitHub hosted runners?
  • Intel OpenCL GPU on the Intel ARC runner - already a constrained resource
  • Intel OpenCL GPU on the Intel iGPU on the AMD GPU runner - already a constrained resource
  • Use codeplaysoftware/oneapi-construction-kit - can be used on GitHub hosted runners but full DPC++ support is still in progress
  • Maybe some combination of the above to load balance resources?

Since this patch isn't adding a build/CTS workflow, there should at the very least be an issue to create one.

Agreed. @fabiomestre could you create that please?

@pbalcer
Copy link
Contributor

pbalcer commented Oct 16, 2023

  • Intel OpenCL CPU - could this be used on GitHub hosted runners?

Let's start with this one. Hopefully it's straightforward to do.

  • Intel OpenCL GPU on the Intel ARC runner - already a constrained resource
  • Intel OpenCL GPU on the Intel iGPU on the AMD GPU runner - already a constrained resource
  • Use codeplaysoftware/oneapi-construction-kit - can be used on GitHub hosted runners but full DPC++ support is still in progress
  • Maybe some combination of the above to load balance resources?

I wouldn't want to add too many additional jobs on the existing runners, the queue times are already significant. I'm hoping we can either add more platforms or be more efficient with what we have through virtualization. I'm going to ask the team to prioritize adding a new intel-gpu runner in the short-term.

fabiomestre and others added 2 commits October 16, 2023 16:40
@fabiomestre @martygrant
@callumfare @aarongreig
[SYCL][OpenCL] Port OpenCL plugin to Unified Runtime (#10490)
1e8168f 
Co-authored-by: Martin Morrison-Grant <[email protected]>
Co-authored-by: Petr Vesely <[email protected]>
Co-authored-by: Callum Fare <[email protected]>
Co-authored-by: aarongreig <[email protected]>
@fabiomestre
[OpenCL] Follow up changes after moving the adapter
c991a7e 
- Update Cmake to use local adapter source files
- Update license headers
- Add virtual memory entrypoints to interface_loader
- Add .clang-format
- Update CODEOWNERS file for OpenCL adapter
@fabiomestre fabiomestre force-pushed the fabio/add_opencl_adapter branch from 97c17e9 to c991a7e Compare October 16, 2023 15:43
@fabiomestre fabiomestre mentioned this pull request Oct 16, 2023
Closed
@fabiomestre
Copy link
Contributor Author

How do we plan on testing this adapter? using a CPU runtime (would it be possible to do that on GH-hosted runner)? something else?

These are the options:

  • Intel OpenCL CPU - could this be used on GitHub hosted runners?
  • Intel OpenCL GPU on the Intel ARC runner - already a constrained resource
  • Intel OpenCL GPU on the Intel iGPU on the AMD GPU runner - already a constrained resource
  • Use codeplaysoftware/oneapi-construction-kit - can be used on GitHub hosted runners but full DPC++ support is still in progress
  • Maybe some combination of the above to load balance resources?

Since this patch isn't adding a build/CTS workflow, there should at the very least be an issue to create one.

Agreed. @fabiomestre could you create that please?

Created this issue to track the task: #964

@martygrant martygrant mentioned this pull request Oct 17, 2023
Merged
@pbalcer
Copy link
Contributor

pbalcer commented Oct 17, 2023 •
edited
Loading

There's no point in waiting for CI because the runners are out of commission today, and the adapter this PR is adding isn't built by any workflow anyway. So I think we should just merge it to unblock other work (like #966).

@fabiomestre fabiomestre merged commit 1f149fb into oneapi-src:adapters Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbenzie kbenzie kbenzie approved these changes

@pbalcer pbalcer pbalcer approved these changes

@martygrant martygrant martygrant approved these changes

+1 more reviewer

@veselypeta veselypeta veselypeta approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fabiomestre @pbalcer @kbenzie @martygrant @veselypeta