[UR][L0] Add support for passing device list to urProgramBuild #911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jandres742
force-pushed
the
multiDevProgramBuild
branch
2 times, most recently
from
90abeed to
4bb5d3f
Compare
jandres742
changed the title
|
intel/llvm pre-merge testing in intel/llvm#11371 |
piProgramBuild receives a list of devices, while urProgramBuild does not. This produces a series of issues when a UR program needs to be created for a specific device. So define a new API, called urProgramBuildExp to pass this list. Signed-off-by: Jaime Arteaga <[email protected]>
pbalcer
reviewed
Oct 2, 2023
| @@ -87,6 +87,7 @@ UR_DLLEXPORT ur_result_t UR_APICALL urGetProgramProcAddrTable( | |||
| return result; | |||
| } | |||
| pDdiTable->pfnBuild = urProgramBuild; | |||
| pDdiTable->pfnBuildExp = urProgramBuildExp; | |||
There was a problem hiding this comment.
Suggested change
| pDdiTable->pfnBuildExp = urProgramBuildExp; | |
| pDdiTable->pfnBuildExp = nullptr; |
|
Superceed by #919 based on the v0.7.x branch, #924 based on main, and the multi-device-compile-hotfix branch based on 3c6f02c. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
piProgramBuild receives a list of devices, while urProgramBuild does not. This produces a series of issues when a UR program needs to be created for a specific device.
So define a new API, called urProgramBuildExp to pass this list.