Skip to content

[umf] Fix macOS build #853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 11, 2023
Merged

[umf] Fix macOS build #853

merged 1 commit into from
Sep 11, 2023

Conversation

kbenzie
Copy link
Contributor

@kbenzie kbenzie commented Sep 11, 2023 •
edited
Loading

The AppleClang compiler emits warnings in C functions with zero arguments that are not specified as f(void).

@kbenzie
[umf] Fix macOS build
065edc1 
The AppleClang compiler emits warnings in C functions with zero
arguments that are not specified as `f(void)`.
pbalcer
pbalcer approved these changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@pbalcer pbalcer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should fail on any compiler with -Wall enabled. There's still something wrong with our cmakes... :/

@kbenzie
Copy link
Contributor Author

kbenzie commented Sep 11, 2023

this should fail on any compiler with -Wall enabled. There's still something wrong with our cmakes... :/

this was also picked up in the github actions, not sure how it creeped in to main

@kbenzie kbenzie merged commit 172bc24 into oneapi-src:main Sep 11, 2023
@kbenzie kbenzie deleted the benie/fix-macos-build branch January 29, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pbalcer pbalcer pbalcer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kbenzie @pbalcer