[umf] extend error message for disjoint pool #841
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbalcer
approved these changes
Sep 1, 2023
pbalcer
reviewed
Sep 1, 2023
|
|
||
| umfMemoryProviderGetLastNativeError( | ||
| umfGetLastFailedMemoryProvider(), &message, &error); | ||
| std::cout << "Native error msg: " << message |
There was a problem hiding this comment.
On second thought, coverity will complain that this can throw.
Can we use our logging framework?
There was a problem hiding this comment.
Oh, right. Yeah, ideally we would use some logger here but I don't want to hardcode our UR logger since we plan to move DisjointPool to another repo anyway. There are other places in this file that use cout so perhaps we can just ignore the issues on coverity for now?
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make debugging easier when
memoryProviderFreein ~Slab fails.We should also implement get_last_native_error` for adapters to set the error message correctly.