Skip to content

[UR] Fixup minor CTS issues #835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 1, 2023
Merged

[UR] Fixup minor CTS issues #835

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions test/conformance/event/urEventSetCallback.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,20 +168,21 @@ using urEventSetCallbackNegativeTest = uur::event::urEventTest;
void emptyCallback(ur_event_handle_t hEvent, ur_execution_info_t execStatus,
void *pUserData) {}

TEST_P(urEventSetCallbackNegativeTest, InvalidNullHandle) {

TEST_P(urEventSetCallbackNegativeTest, InvalidNullHandleEvent) {
ASSERT_EQ_RESULT(
urEventSetCallback(
nullptr,
ur_execution_info_t::UR_EXECUTION_INFO_EXECUTION_INFO_QUEUED,
emptyCallback, nullptr),
UR_RESULT_ERROR_INVALID_NULL_HANDLE);
}

TEST_P(urEventSetCallbackNegativeTest, InvalidNullPointerCallback) {
ASSERT_EQ_RESULT(
urEventSetCallback(
event, ur_execution_info_t::UR_EXECUTION_INFO_EXECUTION_INFO_QUEUED,
nullptr, nullptr),
UR_RESULT_ERROR_INVALID_NULL_HANDLE);
UR_RESULT_ERROR_INVALID_NULL_POINTER);
}

TEST_P(urEventSetCallbackNegativeTest, InvalidEnumeration) {
Expand Down
4 changes: 2 additions & 2 deletions test/conformance/memory/urMemGetInfo.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,11 +63,11 @@ TEST_P(urMemGetInfoTest, InvalidNullPointerParamValue) {
size_t mem_size = 0;
ASSERT_EQ_RESULT(urMemGetInfo(buffer, UR_MEM_INFO_SIZE, sizeof(mem_size),
nullptr, nullptr),
UR_RESULT_ERROR_INVALID_SIZE);
UR_RESULT_ERROR_INVALID_NULL_POINTER);
}

TEST_P(urMemGetInfoTest, InvalidNullPointerPropSizeRet) {
ASSERT_EQ_RESULT(
urMemGetInfo(buffer, UR_MEM_INFO_SIZE, 0, nullptr, nullptr),
UR_RESULT_ERROR_INVALID_SIZE);
UR_RESULT_ERROR_INVALID_NULL_POINTER);
}